PART 1 - Add secondary filter to the v2 results page #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the parameter is the same as production `subjects`.
tomas-stefano
added
the
deploy
tomas-stefano
commented
Dec 20, 2024
| @@ -126,6 +126,37 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'when filter by secondary subjects' do | |||
There was a problem hiding this comment.
@Nitemaeric I added to the features folder for now. I will move everything to system spec in another PR not this one. And divide the filters also in the future PR.
Nitemaeric
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add secondary filter to the
/v2/results.Part 1 / Part 2 / 3 considerations
I divided this work in three parts (and will be three PRs):
Changes proposed in this pull request
Guidance to review